Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

artifactory oidc #6

Merged
merged 1 commit into from
Nov 14, 2024
Merged

artifactory oidc #6

merged 1 commit into from
Nov 14, 2024

Conversation

finn-block
Copy link
Member

Overview

Include a summary of the change and link to the issue it addresses.

Description

Include context, motivation, brief description, and an impact of the change(s). List follow-up tasks here.

How Has This Been Tested?

Describe the tests that you ran to verify your changes. Provide instructions for verification.

  • Test A (e.g. Test A - New test that does ... run in ...)
  • Test B

Checklist

Before submitting this PR, please make sure:

  • I have read the CONTRIBUTING document.
  • My code is consistent with the rest of the project
  • I have tagged the relevant reviewers and/or interested parties
  • I have updated the READMEs and other documentation of affected packages

References

Please list relevant documentation (e.g. tech specs, articles, follow up or related work) relevant to this change, and note if the documentation has been updated.

@finn-block finn-block changed the title rtifactory oidc artifactory oidc Oct 2, 2024
@ALRubinger
Copy link
Contributor

Hey @finn-tbd is still still a DRAFT? Should we rebase on main and keep it going?

@finn-block
Copy link
Member Author

very much still in draft (see failing CI). I wouldn't have a PR open at all, but the CI doesn't trigger until you open a PR

@finn-block finn-block force-pushed the artifactory-oidc branch 2 times, most recently from 6b00787 to 17b1152 Compare November 14, 2024 22:49
@finn-block finn-block marked this pull request as ready for review November 14, 2024 22:58
Copy link
Contributor

@ALRubinger ALRubinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure let's give it a shot

@finn-block finn-block merged commit 6372efd into main Nov 14, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants