Initial implementation #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf31o2
approved these changes
Apr 26, 2022
internal/config/config.go
Outdated
| NetworkMagic uint32 `yaml:"networkMagic" envconfig:"NODE_NETWORK_MAGIC"` | ||
| Address string `yaml:"address" envconfig:"NODE_ADDRESS"` | ||
| Port uint `yaml:"port" envconfig:"NODE_PORT"` | ||
| SocketPath string `yaml:"socketPath" envconfig:"NODE_SOCKET_PATH"` |
There was a problem hiding this comment.
These should use the "standard" Cardano variables, IMO... CARDANO_NODE_SOCKET_PATH is used in the upstream scripts. If we're going to have environment variables, they might as well match what the entrypoint scripts do in the cardano-submit-api image.
570ac37 to
186cdf7
Compare
wolf31o2
approved these changes
Apr 26, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.