Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Acquire nil point #770

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix: Acquire nil point #770

merged 1 commit into from
Oct 28, 2024

Conversation

igorcrevar
Copy link
Contributor

If localtxmonitor => Acquire is called with a nil point (indicating the latest point), a bug occurs because the logger attempts to print the point's Hash and slot, even though point is nil

@igorcrevar igorcrevar requested a review from a team as a code owner October 28, 2024 15:19
@igorcrevar igorcrevar changed the title Acquire nil fix fix: Acquire nil point Oct 28, 2024
wolf31o2
wolf31o2 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@wolf31o2 wolf31o2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably not the only place I did this, unfortunately. Thanks for pointing it out and fixing this one. I'll make a pass over all of the recent logging changes to make sure this doesn't happen elsewhere.

@wolf31o2 wolf31o2 merged commit 9f4ee0f into blinklabs-io:main Oct 28, 2024
8 checks passed
@wolf31o2
Copy link
Member

Somehow, that was the only one. Nice find.

@igorcrevar
Copy link
Contributor Author

When will be a new release with this fix? we have one app that depends on it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolf31o2 wolf31o2 wolf31o2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorcrevar @wolf31o2