feat(packages): update Ogmios package with outputs and dependencies #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agaffney
reviewed
Apr 1, 2024
packages/ogmios/ogmios-v6.1.0.yaml
Outdated
| value: 'http://localhost:1337/' | ||
| - name: ogmios_health_url | ||
| description: Ogmios helth URL | ||
| value: 'http://localhost:1337/health' |
There was a problem hiding this comment.
This is the container port, but we'll want to provide the host port for the user. You should be able to get the port mapping with something like {{ .Ports.ogmios["1337"] }}
There was a problem hiding this comment.
This gives me an issue with bad character "["
9cc5d0f to
a2ba91e
Compare
a2ba91e to
13e4677
Compare
agaffney
reviewed
Apr 1, 2024
packages/ogmios/ogmios-v6.1.0.yaml
Outdated
| @@ -20,8 +22,15 @@ installSteps: | |||
| binds: | |||
| - '{{ .Paths.ContextDir }}/node-ipc:/ipc' | |||
| ports: | |||
| - "1337" | |||
| - "1337:1337" | |||
There was a problem hiding this comment.
This will statically map it to host port 1337, which will cause conflicts if you install Ogmios more than once
13e4677 to
c1c3384
Compare
agaffney
reviewed
Apr 1, 2024
packages/ogmios/ogmios-v6.1.0.yaml
Outdated
| description: Ogmios WebSocket & HTTP server URL | ||
| value: 'http://localhost:{{ index (index .Ports "ogmios") "1337" }}' | ||
| - name: health_url | ||
| description: Ogmios helth URL |
Signed-off-by: Ales Verbic <verbotenj@blinklabs.io>
c1c3384 to
e74bca9
Compare
agaffney
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #162 and #164
Test