Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test on 32-bit systems #56

Merged
merged 1 commit into from
Dec 26, 2022
Merged

Fix test on 32-bit systems #56

merged 1 commit into from
Dec 26, 2022

Conversation

schillic
Copy link
Collaborator

See #55 (I found out that the 32-bit version of Julia can be run on 64-bit systems, so debugging was easy).

The problem is that prop has length 2 in the second call to the test function test_state_prop and then only the first entry is initialized. The other entry contains a random number, which is usually a very small number close to 0, and apparently this can cause issues with trunc. So in this PR I just also initialize the second entry. I am not sure whether not initializing was on purpose.

@schillic schillic requested review from blegat and removed request for blegat December 25, 2022 09:49
@schillic schillic requested a review from blegat December 25, 2022 10:10
Copy link
Owner

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blegat blegat merged commit a5bf8fe into master Dec 26, 2022
@schillic schillic deleted the schillic/test_x86 branch March 6, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants