Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue with empty sub-concepts #8

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Fixing issue with empty sub-concepts #8

merged 1 commit into from
Jul 17, 2023

Conversation

neugartf
Copy link
Contributor

@neugartf neugartf commented Jul 2, 2023

Movements like

02/05 02/05 TRASPASO 800,00 984,57

that were missing a sub-concept were not really detected.

@blalop
Copy link
Owner

blalop commented Jul 7, 2023

Hello @neugartf , sorry I made arise some conflicts in test files while merging previous PR :(

@blalop blalop self-requested a review July 7, 2023 15:52
@neugartf neugartf force-pushed the bugfix/movements-with-empty-subconcepts branch from d2e99d9 to 9d1498a Compare July 13, 2023 22:00
@neugartf
Copy link
Contributor Author

No worries! Just rebased it and should be good to go 👍.

@neugartf neugartf force-pushed the bugfix/movements-with-empty-subconcepts branch from 9d1498a to daf83c4 Compare July 13, 2023 22:06
@neugartf
Copy link
Contributor Author

neugartf commented Jul 16, 2023 •
edited
Loading

Could you merge and do a release, @blalop ? 🙏

@blalop blalop merged commit 41921a2 into blalop:main Jul 17, 2023
@blalop
Copy link
Owner

blalop commented Jul 17, 2023

Released!. Also on pypi. Thank you @neugartf !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blalop blalop blalop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neugartf @blalop