generated from Code-Institute-Org/p3-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apparent errors in validation when user types in something during sleep
#39
Labels
blocked
Waiting for input or for another work phase to finish
enhancement
New feature or request
mentor
Mentor suggestions
Comments
blahosyl
added a commit
that referenced
this issue
Apr 16, 2024
This is to improve user experience with apparent "errors" created by the user typing in something during `sleep`. `upper()` also had to be removed from `start`, and the conditionals modified accordingly.
blahosyl
added a commit
that referenced
this issue
Apr 16, 2024
blahosyl
added a commit
that referenced
this issue
Apr 16, 2024
blahosyl
added a commit
that referenced
this issue
Apr 16, 2024
blahosyl
added a commit
that referenced
this issue
Apr 16, 2024
Seem to have introduced a bug:
|
blahosyl
added a commit
that referenced
this issue
Apr 16, 2024
user input is still not always shown correctly in the `except` block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked
Waiting for input or for another work phase to finish
enhancement
New feature or request
mentor
Mentor suggestions
As my mentor had warned me before implementing
sleep
, this causes some strange behaviours with input validation.In the screenshot below, it seems like the program rejects the input
y
, which should be accepted.On closer inspection, however, we can see that the user already entered
y
once, before the next question appeared.Since timeouts with
sleep
enhance the user experience, especially when giving a confirmation message before clearing the screen, I decided not to remove these. Instead, I intend to modify the validation error messages such that they also show the user input that is being rejected.Code to be modified
The text was updated successfully, but these errors were encountered: