Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unified naming and placement for global variables #30

Closed
3 tasks
blahosyl opened this issue Apr 13, 2024 · 0 comments
Closed
3 tasks

Use unified naming and placement for global variables #30

blahosyl opened this issue Apr 13, 2024 · 0 comments
Assignees
@blahosyl
Labels
mentor Mentor suggestions refactoring Refactoring code (no change in functionality)

Comments

@blahosyl
Copy link
Owner

blahosyl commented Apr 13, 2024 •
edited
Loading

Refactoring suggested by my mentor.

This only applies to variables that are changed while the code is running, not constants

  • put all global variables together at the beginning
  • _name can be used to indicated a global variable distinct from constants.
  • explain why I chose the naming convention in the README
@blahosyl blahosyl added mentor Mentor suggestions refactoring Refactoring code (no change in functionality) labels Apr 13, 2024
@blahosyl blahosyl self-assigned this Apr 13, 2024
blahosyl added a commit that referenced this issue Apr 14, 2024
@blahosyl
add study credits to README #4 #30
b2bd754
blahosyl added a commit that referenced this issue Apr 14, 2024
@blahosyl
make global variables distinct in naming #30
647a1a2 
they all start with an underscore
@blahosyl blahosyl changed the title Put all global variables at the top together, use unified but distinct naming Use unified naming and placement for global variables Apr 14, 2024
blahosyl added a commit that referenced this issue Apr 14, 2024
@blahosyl
correct variable capitalization (constant) #30
e0a7c76
blahosyl added a commit that referenced this issue Apr 14, 2024
@blahosyl
document naming conventions #4 #30
a4c3bfe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blahosyl blahosyl

Labels
mentor Mentor suggestions refactoring Refactoring code (no change in functionality)
Projects
Dinner Party Planner
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blahosyl