Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Value/ValueType methods into built-in traits #18

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

IFcoltransG
Copy link
Contributor

Replaces a number of methods on Value and ValueType with names like get_foo_value and new_foo into a single get and new method generic over TryInto<foo>.
With the stylistic change from different methods to generics, comes auto-generated Value constructors from ValueType constructors rather than declaring them all manually, but the main reason is I think it's a bit cleaner to use Rust's built-in traits.

@bladecoder bladecoder merged commit a5d9c17 into bladecoder:main Dec 5, 2024
1 check passed
@IFcoltransG IFcoltransG deleted the value-cleanup branch December 6, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants