Turn off Binkplayer error on external function fallbacks #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And while looking at it again I realised I'd forgotten to change one of the doc-comments in the old PR — updated now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was meant to be #16 but I have no idea what's going on with the commits in that PR due to force pushes, so this PR is a replacement for it.
Currently, Binkplayer throws an error if the provided .ink.json contains a fallback for an external function. With this PR, it does not throw that error unless the -e CLI flag is passed.
The CLI doesn't let you properly handle external functions, so without this change, it's not possible to run Ink with external functions at all, even if they have fallbacks.
I'm also sneaking in a fix for an off-by-one error in the display of randomly chosen choices — happy to cherry-pick into a different PR. My reason for including it is that both changes came from attempting to use that auto_play mode to test an existing Ink story, and finding both issues.