-
-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MSVC and macOS coverage #1748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only got a couple of notes as this all looks pretty great - with them addressed, this looks good to merge.
2269e10
to
f8b5edb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dragonmux thanks for the comments! Bits should've been addressed now.
… to standards compliant mode
f8b5edb
to
65e0210
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging. Thank you for the contribution!
Detailed description
This PR implements CI support for MSVC, Apple Xcode, and Homebrewed GCC for macOS.
For the latter two, dependencies are fetched from Homebrew as:
libftdi
depends on boost and others to be built from scratchThis PR also includes the relevant fixes to make MSVC builds happy, in particular around standards compliance (#1742).
I'm open to any feedback. Let me know what you think!
Your checklist for this pull request
Closing issues