Interceptor filter fixes #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for your submission, We greatly value all contributions. Since I am not involved with the SVG side at all I will loop in @spip01 since he created this project & art. Looks good although I have no idea what the groups do. As for running it locally you can get the variables by using the network tab and copying the content of env.js 🤫. |
|
Thanks @CEbbinghaus with that I was able to test it (And found a mistake in one patch) It works as I expected and should be good to go once it's been reviewed |
|
Thanks for your prompt response. Spip is away for the week but will try to review the changes on the go. Worst case he will get to reviewing it next week :3 Thank you for your contribution <3 |
* Cylon headpieces can't have eyes at all * Only narrow heads can have Pi * Only wide heads can have Octa spot and Quadra spot * Octa spot, quadra spot, and linea filters aren't disabling the other light filters
According to nms.center you can't have mouths without a pommel. A quick search shows this is probably true, with only mislisted hits for mouth without pommel. The ant (Which is a requirement for all mouths) seems to attach to the pommel, so mouths should enable pommel automatically.
More than 10% of the subreddit posts with "guard" in the title also include "hilt" because of confusion around this part. Part of that is due to the layout looking like the hilt goes on the end of the guard, but properly grouping these filters should fix that confusion.
With carriage the spine is always long enough to match up with the carriage thruster hole
Also, you can't have offset-top with X-fin
Groups 13 and 14 change from "All top/bottom x-wings" to "All top/bottom rear x-wings"
And by extension bottom rear and full X-wing U-wing is no longer part of group 11, since it can be combined with rear/full X-wings. For simplicities sake the U-fin is also in group 32 with the U-wing. This means we don't have to add separate okGroup for the U-wing fin for everything that's compatible with uwing. Group 31 is gone (Was U-wing fin)
41 = antenna
42 = fin & pod 43 = I-wing top open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't be sure about these patches because the site won't load locally withFIREBASE_APIundefined. Tested in console on live site though, so it should work.These filter changes are a combination of digging through the nms.center UI and digging through submissions on nmsge.com and the subreddit. If you think I'm wrong about any of these assertions please tell me. This is all me researching by skimming submissions while I wait for a sale, I haven't actually bought the game yet!
I have a list of more complicated filter fixes that I won't be able to implement myself. I'll put them in an issue after this is merged