feat(model): Add a constant for the conan forge
#40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
reviewed
Jan 16, 2025
| @@ -31,6 +31,7 @@ public class Forge extends Stringable { | |||
| public static final Forge CENTOS = new Forge("/", "centos"); | |||
| public static final Forge CODEPLEX = new Forge("/", "codeplex"); | |||
| public static final Forge CODEPLEX_GROUP = new Forge("/", "codeplex_group"); | |||
| public static final Forge CONAN = new Forge(":", "conan"); | |||
There was a problem hiding this comment.
If this really needs to use : as a separator, it should be moved to the section starting at line 66, AFAIU.
The external namespace aka. forge `conan` is present in Black Duck's KB components data sets. So, add the corresponding constant to the `Forge` class. Signed-off-by: Frank Viernau <x9fviern@zeiss.com>
2ab0b28 to
fe50631
Compare
fviernau
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Jan 24, 2025
The known forges, `Forge.getKnowForges()`, defined in `bdio-integration` lacks an entry for the "conan" forge. Fix this with a work around, see also [1]. [1]: blackducksoftware/integration-bdio#40 Signed-off-by: Frank Viernau <x9fviern@zeiss.com>
fviernau
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Jan 24, 2025
The known forges, `Forge.getKnowForges()`, defined in `bdio-integration` lacks an entry for the "conan" forge. Fix this with a work around, see also [1]. [1]: blackducksoftware/integration-bdio#40 Signed-off-by: Frank Viernau <x9fviern@zeiss.com>
fviernau
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Jan 24, 2025
The known forges, `Forge.getKnowForges()`, defined in `bdio-integration` lack an entry for the "conan" forge. Fix this with a work around, see also [1]. [1]: blackducksoftware/integration-bdio#40 Signed-off-by: Frank Viernau <x9fviern@zeiss.com>
fviernau
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Jan 24, 2025
The known forges, `Forge.getKnowForges()`, defined in `bdio-integration` lack an entry for the "conan" forge. Fix this with a work around, see also [1]. [1]: blackducksoftware/integration-bdio#40 Signed-off-by: Frank Viernau <x9fviern@zeiss.com>
fviernau
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Jan 24, 2025
The known forges, `Forge.getKnowForges()`, defined in `bdio-integration` lack an entry for the "conan" forge. Fix this with a work around, see also [1]. [1]: blackducksoftware/integration-bdio#40 Signed-off-by: Frank Viernau <x9fviern@zeiss.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The external namespace aka. forge
conanis present in Black Duck's KB components data sets. So, add the corresponding constant to theForgeclass.