feat: enable openapi spec swagger link in api register #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: add apic api update example
refactor: remove duplicate example for apic create
feat: add examples for create & update apic service with system assigned identity
fix: fix external doc extracting bug in spec
…n-api-register refactor: remove summary setting in api register
blackchoey
reviewed
Oct 10, 2024
| # Raise an error for bad status codes | ||
| response.raise_for_status() | ||
| # Parse the content | ||
| data = json.loads(response.content) |
blackchoey
reviewed
Oct 10, 2024
| data = json.loads(response.content) | ||
| value = json.dumps(data) if data else None | ||
| except requests.exceptions.RequestException as e: | ||
| print(f"Error fetching data from {api_location}: {e}") |
There was a problem hiding this comment.
Please use logger to log the message
blackchoey
reviewed
Oct 10, 2024
| print(f"Error fetching data from {api_location}: {e}") | ||
| value = None | ||
| else: | ||
| # TODO Future Confirm its a file and not link |
blackchoey
reviewed
Oct 10, 2024
Do you mean that if spec api location is a user-provided url link, it is better to set value=this link? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.