This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Adding shrinkwrap.json #272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 58 58
Lines 1349 1349
Branches 200 200
=====================================
Hits 1349 1349
Continue to review full report at Codecov.
|
|
Well, dequelabs/axe-core#516 was patched and released before we were able to get this in. Windows builds are working correctly now. @Blackbaud-SteveBrush, any chance to use the logic here to solve our NPM5 problems in #260? |
|
Close this in favor of #274. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to quickly solve a transitive dependency bug before we're able to adopt NPM5 +
package-lock.json, this PR introducesshrinkwrap.json. Similar to the behavior @Blackbaud-SteveBrush was seeing in upgrading to NPM5, I've had to rework how we pull in the local version of builder to test commands.