Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/770 upgrade dependencies #218

Merged
merged 8 commits into from
Feb 4, 2025
Merged

Conversation

caebr
Copy link
Collaborator

@caebr caebr commented Feb 4, 2025

Umsetzung von Punkt 1 (Dependencies aktualisieren) -> bkd-mba-fbi/webapp-schulverwaltung#770

@caebr caebr requested a review from hupf February 4, 2025 10:13
@caebr caebr self-assigned this Feb 4, 2025
Copy link
Collaborator

@hupf hupf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finde es gut 👍

Habe noch ein paar Details kommentiert.

doc/lifecycle.md Outdated
To update to a newer version of Angular, see the official [Update Guide](https://angular.dev/update-guide).

- Check that all Angular libraries (e.g. `ng-bootstrap`, `ng-translate`) are compatible with the target Angular version
- Update Angular to the newer version using the [Update Guide](https://angular.dev/update-guide)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Da würde ich dann auch "target version" nehmen.

doc/lifecycle.md Outdated
- Check that all Angular libraries (e.g. `ng-bootstrap`, `ng-translate`) are compatible with the target Angular version
- Update Angular to the newer version using the [Update Guide](https://angular.dev/update-guide)
- Update the Angular libraries (check changelogs for breaking changes)
- See the [Angular release blog post](https://blog.angular.dev/) for optional migrations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vielleicht so?

Check the [Angular release blog post](https://blog.angular.dev/) for optional migrations and new features

doc/lifecycle.md Outdated
- You can use the interactive mode to selectively apply the updates: `npx npm-check-updates -i`
- Patch / minor updates can usually be applied without problems
- For major updates, check each package's changelog / migration guide for breaking changes
- See [Update Prettier Version](./prettier.md#update-prettier-version)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vielleicht könnte man es hier auch gleich beschreiben?

When Prettier is updated, the source code must be reformated, see [Update Prettier Version](./prettier.md#update-prettier-version)


# Lifecycle

Before starting a new development phase, we usually update the frameworks and dependencies first.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich frage mich noch, ob wir dies hier so beschreiben wollen/sollen, oder ob es diesen Satz gar nicht braucht?

Vielleicht würde ich das ganze noch in eine Subsection «Update Dependencies» moven und noch eine weitere Subsection «Uncluttering» hinzufügen, wo wir npm run unsed (Knip) beschreiben? Wir haben das schon im Setup drin, aber ich fänd es hier eigentlich fast passender. Was meinst du?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weiter könnten wir vielleicht bei «Angular» und bei «Other dependencies» am Schluss einen Punkt hinzufügen:

- Make sure that all tests and linting are successful. If appropriate, test certain components/aspects manually.

@caebr caebr merged commit ba66e4f into main Feb 4, 2025
4 checks passed
@caebr caebr deleted the feature/770-upgrade-dependencies branch February 4, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants