Fix redirect loop when token is already expired #63 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Siehe #63
Es gab ein Redirect Loop, wenn das Access Token ablief oder wen. die Seite neu geladen wurde und das Access Token war bereits expired. Mit diesem Change wird nur ein Timer gesetzt, wenn das Token nicht bereits abgeloffen ist – bei Tokens die bereits abgelaufen sind greift die normale Logik in
auth.ts, wenn man auf die Seite kommt.Kann getestet werden mit der
browserstackClient ID mitnpm run start:browserstack(Access Token ist dort 2 Minuten gültig). Für mehr Transparent inlogging.tsdie Variableconst loggingEnabled = true;setzen (ist ein Production Build, deshalb wird sonst nicht geloggt).