Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/562 notification component #142

Merged
merged 39 commits into from
Dec 21, 2023
Merged

Feature/562 notification component #142

merged 39 commits into from
Dec 21, 2023

Conversation

caebr
Copy link
Collaborator

@caebr caebr commented Dec 13, 2023

Siehe #160

Das Thema "DropdownController" habe ich jetzt noch nicht angeschaut.

@caebr caebr requested a review from hupf December 13, 2023 12:34
@caebr caebr self-assigned this Dec 13, 2023
@caebr caebr force-pushed the feature/562-notification-component branch from 1a6fa92 to 6c19ba1 Compare December 13, 2023 13:48
@caebr caebr mentioned this pull request Dec 14, 2023
Merged
hupf
hupf approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@hupf hupf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sieht gut aus 👍
Habe ein paar Details kommentiert, ich würe vo allem das Setting überprüfen und die Logik in der Toggle Komponente umsetzen statt im Dropdown. Muss dann noch an den neuen DropdownController angepasst werden...

@caebr caebr force-pushed the feature/562-notification-component branch from 6c19ba1 to 54d8eaf Compare December 18, 2023 10:08
caebr added 24 commits December 19, 2023 16:48
@caebr
Remove main schulverwaltung app bundles required for notifications #562
93b7b6e
@caebr
Add new notifications toggle component #562
83521f1
@caebr
Use bell svg from figma #562
5374c10
@caebr
Add notification dropdown #562
0980653
@caebr
Style notification dropdown #562
697d3d7
@caebr
Add translations #562
33ef7b8
@caebr
Style disabled button #562
15fff0a
@caebr
Add counter circle #562
4ff0685
@caebr
Add fetch method to get notification data / user settings #562
057ab14
@caebr
Show number of notifications #562
3fba1ea
@caebr
Pass notification to dropdown #562
1c2ff80
@caebr
Display notifications #562
f7f06e5
@caebr
Sanitize html with dom purify #562
78ab332
@caebr
Add delete button #562
4a89e85
@caebr
WIP: Delete notifications #562
49e744f
@caebr
Fix tests #562
c84e3a5
@caebr
Refactor render notification data #562
076095e
@caebr
Delete one or all notifications#562
82d5f71
@caebr
Update ui after notification deletion #562
895e29d
@caebr
Use get env settings helper #562
d957e71
@caebr
WIP: Refactor layout #562
5bed9e7
@caebr
Add notification refresh time to env settings #562
575cbe5
@caebr
Add notification refresh time to env settings #562
cbfccde
@caebr
Refactor mobile layout #562
dd794d1
@caebr caebr force-pushed the feature/562-notification-component branch from a39284e to 95e844a Compare December 19, 2023 15:48
@caebr caebr force-pushed the feature/562-notification-component branch from 6eee94d to 6d89b7e Compare December 21, 2023 09:49
@caebr caebr force-pushed the feature/562-notification-component branch from 6d89b7e to 3e7a76f Compare December 21, 2023 10:05
@caebr caebr merged commit 9b8e208 into main Dec 21, 2023
2 checks passed
@caebr caebr deleted the feature/562-notification-component branch December 21, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hupf hupf hupf approved these changes

Assignees

@caebr caebr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caebr @hupf