Add support for remaining unsupported ASTC formats #2963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new ASTC formats into pixelformats example and ninja scripts Rebuild ASTC textures
|
Update IDL... Bump version here: Add formats here: Line 525 in 000d09d Then run |
bkaradzic
reviewed
Oct 25, 2022
| , "textures/texture_compression_astc_6x6.dds" | ||
| , "textures/texture_compression_astc_8x5.dds" | ||
| , "textures/texture_compression_astc_8x6.dds" | ||
| , "textures/texture_compression_astc_8x8.dds" |
There was a problem hiding this comment.
Flip comma placement to the end of line...
bkaradzic
reviewed
Oct 25, 2022
| @@ -193,74 +193,82 @@ typedef enum bgfx_texture_format | |||
| BGFX_TEXTURE_FORMAT_ATC, /** (17) ATC RGB 4BPP */ | |||
| BGFX_TEXTURE_FORMAT_ATCE, /** (18) ATCE RGBA 8 BPP explicit alpha */ | |||
| BGFX_TEXTURE_FORMAT_ATCI, /** (19) ATCI RGBA 8 BPP interpolated alpha */ | |||
| BGFX_TEXTURE_FORMAT_ASTC4X4, /** (20) ASTC 4x4 8.0 BPP */ | |||
There was a problem hiding this comment.
Once you update IDL this file will be regenerated...
Move comma in pixelformats
|
Didn't know about the idl, done now! |
mipek
pushed a commit
to mipek/bgfx
that referenced
this pull request
Mar 2, 2024
* Add support for remaining unsupported ASTC formats Add new ASTC formats into pixelformats example and ninja scripts Rebuild ASTC textures * Update idl and generate Move comma in pixelformats Co-authored-by: Raziel Alphadios <raziely@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for remaining unsupported ASTC formats
Add new ASTC formats into pixelformats example and ninja scripts
Rebuild ASTC textures