Fix textureXXXBias() macro definitions for glsl >= 130 #2954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkaradzic
requested changes
Oct 13, 2022
src/bgfx_shader.sh
Outdated
| # define textureCubeBias(_sampler, _coord, _bias) textureCube(_sampler, _coord, _bias) | ||
|
|
||
| # if BGFX_SHADER_LANGUAGE_GLSL >= 130 | ||
| # if BGFX_SHADER_LANGUAGE_GLSL < 130 |
There was a problem hiding this comment.
This is wrong, because BGFX_SHADER_LANGUAGE_GLSL is 0 when it's not GLSL. Keep old #if logic, and move this part into #else block.
2ef8e78 to
29496cc
Compare
mipek
pushed a commit
to mipek/bgfx
that referenced
this pull request
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
texture2DBias() was defined in term of texture2D() which was then redefined with the bias parameter stripped (leads to a shader compilation error)