Fixing problem with Android armv7 optmization which causes alignment violation #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not supported tested on the full range of iOS devices from iPhone 5s to iPhone 11
bkaradzic
requested changes
Jun 30, 2020
| @@ -1869,7 +1869,7 @@ namespace bgfx | |||
| frameNoRenderWait(); | |||
|
|
|||
| m_encoderHandle = bx::createHandleAlloc(g_allocator, _init.limits.maxEncoders); | |||
| m_encoder = (EncoderImpl*)BX_ALLOC(g_allocator, sizeof(EncoderImpl)*_init.limits.maxEncoders); | |||
| m_encoder = (EncoderImpl*)BX_ALIGNED_ALLOC(g_allocator, sizeof(EncoderImpl)*_init.limits.maxEncoders, 16); | |||
There was a problem hiding this comment.
You must match freeing with BX_ALIGNED_FREE...
rozgo
pushed a commit
to VertexStudio/bgfx
that referenced
this pull request
Aug 14, 2020
… violation (bkaradzic#2188) * Fixing problem with Android armv7 optmization which causes alignment violation
pigpigyyy
added a commit
to pigpigyyy/bgfx
that referenced
this pull request
Mar 11, 2021
* master: update sdf see bkaradzic#2193 (bkaradzic#2196) Added ability to disable discrete GPU selection. Cleanup. Cleanup. Updated spirv-cross. Updated spirv-tools. Updated glslang. fix declaration of sdfCoverageToDistance (bkaradzic#2193) Fixed issue bkaradzic#2192. 02-metaballs: Added settings. Fixes for D3D12 on Linux. Updated ImGui. Fixing problem with Android armv7 optmization which causes alignment violation (bkaradzic#2188)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.