Allow passing config macros from env #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozgo
pushed a commit
to VertexStudio/bgfx
that referenced
this pull request
Aug 14, 2020
pigpigyyy
added a commit
to pigpigyyy/bgfx
that referenced
this pull request
Mar 11, 2021
* master: Allow passing config macros from env (bkaradzic#2147) Update examples to build on Emscripten Wasm. Add separate wasm and wasm2js targets. (bkaradzic#2145) Updated meshoptimizer. Updated ImGui. Updated vulkan headers. Updated spirv-cross. Updated spirv-tools. Updated glslang. Cleanup. Fixed build. Cleanup dead code (bkaradzic#2143) Updated ImGui. Updated ImGui. Reverted bkaradzic#2021.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bgfx defines many config macros in
src/config.h. If it allows changing these macros before generating projects would be better.For examples, we can use
to change
BGFX_DEFINE_MAX_COMMAND_BUFFER_SIZEandBGFX_DEFINE_MAX_INSTANCE_DATA_COUNT.