Fix webgl2 instancing bug #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pigpigyyy
added a commit
to pigpigyyy/bgfx
that referenced
this pull request
Nov 29, 2018
* master: (63 commits) Updated glslang. shaderc: Updated version. Updated docs. Added frame buffer resolve control. Updated ImGui. Add Unbind Attributes (bkaradzic#1515) Added numBackBuffers to initialization parameters. 01-cubes: Fixed topology to match combo box. Updated glslang. Fix webgl2 instancing bug (bkaradzic#1512) Updated ImGui. Updated docs. Cleanup. Fixed caps. Fixed depth format validation. Fixed bkaradzic#1431. Cleanup. Metal: Added magnification filter setting. Updated ImGui. Updated ImGui. ...
pigpigyyy
added a commit
to pigpigyyy/bgfx
that referenced
this pull request
Oct 14, 2022
* master: (161 commits) Updated glslang. shaderc: Updated version. Updated docs. Added frame buffer resolve control. Updated ImGui. Add Unbind Attributes (bkaradzic#1515) Added numBackBuffers to initialization parameters. 01-cubes: Fixed topology to match combo box. Updated glslang. Fix webgl2 instancing bug (bkaradzic#1512) Updated ImGui. Updated docs. Cleanup. Fixed caps. Fixed depth format validation. Fixed bkaradzic#1431. Cleanup. Metal: Added magnification filter setting. Updated ImGui. Updated ImGui. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug which cause instancing to simply fail with WebGL 2
The cause is that the instancing attributes are never disabled after having been used. In WebGL 2, specifically, this will cause the next draw call to fail. This fixes the problem by disabling instancing attributes when they were used.