support for the Nsight Tegra Android VSI #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Naming seems fine, since VS requires specific platform string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for generating Visual Studio 2015 projects that target Android via the NVIDIA Nsight Tegra tools, found here:
https://developer.nvidia.com/nvidia-nsight-tegra
I had a bit of a hairy merge to isolate this, so shout if there's anything in the change that looks like it shouldn't be there. Some other small fixes may have snuck in.
There's probably some discussion that could be had around naming. For example, should this be more specific than just "Android," if there's an intent to add support for VS 2017's own Android targeting? Is "TegraAndroid" the right platform name, or should it be something more verbose but specific? "NNTAndroid"? Should the new
android*props inapi.luaalso be supported in Makefiles? Etc.