-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pen color selection #83
Conversation
f2006b8
to
e8178c4
Compare
Thanks for the contribution! This does not work for me yet, though: The dialog pops up, I can choose a colour, but the painting colour stays red... Any idea what to do/look at? |
Oh! Interesting. gdk_cairo_set_source_rgba(data->default_pen->paint_ctx, data->default_pen->paint_color); If should display "test" after you validate the color. |
Yeah, that fires. |
Thank you for the feed back @bk138 ! |
Might this relate to differing gtk versions? |
I just realized that using the default branch, I cannot erase using right or middle button. |
Ok, I manage to reproduce the bug: I forgot to set a configuration file. This explains that I wasn't able to erase using right click. |
Hi! |
Some of this can be used for #110, so I'd like to keep a reference once work starts on that. Closing as this PR will not be merged as-is, but code will be re-used. |
Great! |
This PR adds the feature of choosing color from the menu.
Fix #71