Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated mcmc docs #73

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Updated mcmc docs #73

merged 3 commits into from
Sep 13, 2024

Conversation

Harry-Rich
Copy link
Contributor

  • Changed log_posterior function to use previously defined gp multivariate normal distribution as opposed to matrix method to improve clarity

  • Changed some of the wording around posterior and liklihood for clarity, anything after the definition of the prior is the combination of the prior and the liklihood and so therefore the posterior? Let me know your thoughts

Copy link
Collaborator

@arm61 arm61 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Some thoughts:

  • Any additional clarity improvement could be to split the log_prior and log_likelihood into two functions, up to you though.
  • Any thoughts on improvements to the companion text?

@Harry-Rich
Copy link
Contributor Author

Split likelihood function and prior function. Haven't changed accompanying text yet wanted to have a conversation about it. Don't know why executions are not showing as null? I am clearing all outputs and resetting the kernel before commiting

@arm61
Copy link
Collaborator

arm61 commented Sep 13, 2024

I suggest we merge this and can look at the wording later.

@arm61 arm61 merged commit f1f6f17 into bjmorgan:master Sep 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants