Removed canMakePayments check on purchase method #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@puchog this is a great catch! Thank you for contributing! |
|
@puchog apart from the replication you described (turn off "installing apps"), did you find anything else that incorrectly causes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check is giving some troubles, returning bad values.
Easy way to check this is setting "Installing Apps" on Itunes & App Store restriction, canMakePayments should return YES, but its returning NO.
We was facing some production users of our app that reported other issues with the same check.
This lead us to a 30% decrease on our purchases.
Since this check is not required because the normal purchase flow will not let you buy anyway if the restrictions are set up, I removed it.
It seems to be related with this issue: https://forums.developer.apple.com/thread/22312