Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove localizedIntroductoryPrice (restore Xcode 8 compatibility) #320

Merged
merged 3 commits into from
Dec 20, 2017
Merged

Remove localizedIntroductoryPrice (restore Xcode 8 compatibility) #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96a5956
Remove localizedIntroductoryPrice, introductoryPrice
bizz84 Dec 20, 2017
716af4a
Update CHANGELOG
bizz84 Dec 20, 2017
423d2ea
Update CHANGELOG
bizz84 Dec 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

All notable changes to this project will be documented in this file.

## [0.11.2](https://github.com/bizz84/SwiftyStoreKit/releases/tag/0.11.2) Remove `SKProduct.localizedIntroductoryPrice`

* Remove `localizedIntroductoryPrice` ([#320](https://github.com/bizz84/SwiftyStoreKit/pull/320), see [#319](https://github.com/bizz84/SwiftyStoreKit/issues/319), [#318](https://github.com/bizz84/SwiftyStoreKit/pull/318), [#315](https://github.com/bizz84/SwiftyStoreKit/pull/315))

## [0.11.1](https://github.com/bizz84/SwiftyStoreKit/releases/tag/0.11.1) Add `PaymentTransaction.transactionDate` and `SKProduct.localizedIntroductoryPrice`

* Add `transactionDate` to `PaymentTransaction` ([#316](https://github.com/bizz84/SwiftyStoreKit/pull/316), see [#312](https://github.com/bizz84/SwiftyStoreKit/issues/312)).
Expand Down
22 changes: 7 additions & 15 deletions SwiftyStoreKit/SKProduct+LocalizedPrice.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,21 +28,13 @@ import StoreKit
public extension SKProduct {

public var localizedPrice: String? {
return formattedPrice(price: price, locale: priceLocale)
return priceFormatter(locale: priceLocale).string(from: price)
}

@available(iOS 11.2, OSX 10.13.2, tvOS 11.2, *)
public var localizedIntroductoryPrice: String? {
guard let introductoryPrice = introductoryPrice else {
return nil
}
return formattedPrice(price: introductoryPrice.price, locale: introductoryPrice.priceLocale)
}

private func formattedPrice(price: NSDecimalNumber, locale: Locale) -> String? {
let numberFormatter = NumberFormatter()
numberFormatter.locale = locale
numberFormatter.numberStyle = .currency
return numberFormatter.string(from: price)

private func priceFormatter(locale: Locale) -> NumberFormatter {
let formatter = NumberFormatter()
formatter.locale = locale
formatter.numberStyle = .currency
return formatter
}
}