-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add localized attributes for subscription period and introductory period to SKProduct #315
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| // | ||
| // SKProduct+LocalizedPrice.swift | ||
| // SwiftyStoreKit | ||
| // | ||
| // Created by Andrea Bizzotto on 19/10/2016. | ||
| // Copyright (c) 2015 Andrea Bizzotto (bizz84@gmail.com) | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in | ||
| // all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
|
|
||
| import StoreKit | ||
|
|
||
| public extension SKProduct { | ||
|
|
||
| public var localizedPrice: String? { | ||
| let numberFormatter = NumberFormatter() | ||
| numberFormatter.locale = self.priceLocale | ||
| numberFormatter.numberStyle = .currency | ||
| return numberFormatter.string(from: self.price) | ||
| } | ||
|
|
||
| @available(iOS 11.2, OSX 10.13.2, *) | ||
| public var localizedIntroductoryPrice: String? { | ||
| guard let price = introductoryPrice?.price, let locale = introductoryPrice?.priceLocale else { return nil } | ||
| let numberFormatter = NumberFormatter() | ||
| numberFormatter.locale = locale | ||
| numberFormatter.numberStyle = .currency | ||
| return numberFormatter.string(from: price) | ||
| } | ||
|
|
||
| @available(iOS 11.2, OSX 10.13.2, *) | ||
| public var localizedSubscriptionPeriod: String? { | ||
| guard let subscriptionPeriod = subscriptionPeriod else { return nil } | ||
| return localizedPeriod(period: subscriptionPeriod) | ||
| } | ||
|
|
||
| @available(iOS 11.2, OSX 10.13.2, *) | ||
| public var localizedIntroductoryPeriod: String? { | ||
| guard let introductoryPeriod = introductoryPrice?.subscriptionPeriod else { return nil } | ||
| return localizedPeriod(period: introductoryPeriod) | ||
| } | ||
|
|
||
| @available(iOS 11.2, OSX 10.13.2, *) | ||
| private func localizedPeriod(period: SKProductSubscriptionPeriod) -> String { | ||
| switch period.unit { | ||
| case .day: return String(format: NSLocalizedString("localized subscription period day", comment: "localized subscription period day"), arguments: [period.numberOfUnits]) | ||
| case .week: return String(format: NSLocalizedString("localized subscription period week", comment: "localized subscription period week"), arguments: [period.numberOfUnits]) | ||
| case .month: return String(format: NSLocalizedString("localized subscription period month", comment: "localized subscription period month"), arguments: [period.numberOfUnits]) | ||
| case .year: return String(format: NSLocalizedString("localized subscription period year", comment: "localized subscription period year"), arguments: [period.numberOfUnits]) | ||
| } | ||
| } | ||
|
|
||
| } | ||
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method introduces arbitrary localized strings which are not defined in a strings table.
I think it should be up to users to decide how to format these (in other words, this is application business logic).
In short, I believe it could be convenient to introduce
localizedIntroductoryPriceas you have done, but I would leavelocalizedSubscriptionPeriodandlocalizedIntroductoryPeriodout of this PR.I might borrow some of your code to calculate
localizedIntroductoryPriceand make a separate PR to show my proposed approach.