Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danger Integration #215

Merged
merged 6 commits into from
May 18, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ osx_image: xcode8.3

install:
- ./scripts/install_swiftlint.sh
- bundle install --path vendor/bundle

script:
- swiftlint
- ./scripts/build.sh
- bundle exec danger --verbose
30 changes: 30 additions & 0 deletions Dangerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# Ensure there is a summary for a pull request
fail 'Please provide a summary in the Pull Request description' if github.pr_body.length < 5

# Warn about develop branch
warn("Please target PRs to `develop` branch") if github.branch_for_base != "develop"

# Sometimes it's a README fix, or something like that - which isn't relevant for
# including in a project's CHANGELOG for example
declared_trivial = github.pr_title.include? "#trivial"

# Make it more obvious that a PR is a work in progress and shouldn't be merged yet
warn("PR is classed as Work in Progress") if github.pr_title.include? "[WIP]"

# Warn no CHANGELOG
warn("No CHANGELOG changes made") if git.lines_of_code > 50 && !git.modified_files.include?("CHANGELOG.md") && !declared_trivial

# Warn when there is a big PR
warn("Big PR") if git.lines_of_code > 500

## Let's check if there are any changes in the project folder
has_app_changes = !git.modified_files.grep(/SwiftyStoreKit/).empty?

## Then, we should check if tests are updated
has_test_changes = !git.modified_files.grep(/SwiftyStoreKitTests/).empty?

## Finally, let's combine them and put extra condition
## for changed number of lines of code
if has_app_changes && !has_test_changes && git.lines_of_code > 20
fail("Tests were not updated", sticky: false)
end
3 changes: 3 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
source 'https://rubygems.org'

gem 'danger'