Resolved repurchasing a non-consumable not calling completion, on macOS.

[Megatron1000]

I also had this same issue. #98

On OSX at least, when you attempt to make a payment for a non-consumable product that's already been purchased by that account the transaction result comes back as a restore. Because of the if condition in the restore case, the transaction transactionResults would never get updated.

I've only tested this on OSX, so I can't comment on the behaviour on iOS, but from reading the code I can't see the point in the isPurchaseRequest boolean. I've reduced the protection so all it does now is avoid doing anything with non matching products identifiers, only when you're purchasing, not restoring.

[bizz84]

@Megatron1000 Thank you for the PR!

I will be doing some testing on iOS in due course and verify if some changes are needed to make this work on all platforms.

[aporat]

this is also an issue on iOS.

if the user already purchased a specific product, but the finishTransaction wasn't call after the purchase, the same issue happens. next time the user tries to purchase the same product, a dialog will show up "This in-App Purchase has already been bought. It will be restored for free". However, the SwiftyStoreKit.purchaseProduct does not call the completion block (with neither success or failure)

[aporat]

sorry, seems my issue is related to SKPaymentTransactionObserver and not to the library itself.

after some debugging, it seems SKPaymentTransactionObserver will not call the func paymentQueue(_ queue: SKPaymentQueue, updatedTransactions transactions: [SKPaymentTransaction]) in specific cases.

the dialog "This in-App Purchase has already been bought. It will be restored for free" shows up, but the SKPaymentTransactionObserver doesn't trigger the restore / purchase event.

[doffen]

I prefer adding THIS change to replace new line 146 of InAppProductPurchaseRequest.swift:
if isPurchaseRequest {
transactionResults.append(.restored(product: product))
} else {
transactionResults.append(.purchased(product: product))
}

With this modification, when you go to purchase a previously-purchased product, it returns in the same way as a new purchase would return (since the calling software doesn't need to distinguish between these two cases -- it just needs to know success or failure). I found the callbacks were getting messed up without this change.

[bizz84]

This PR is outdated following upcoming changes to the purchase flows in SwiftyStoreKit. See new PR: #131

@Megatron1000 @doffen @aporat Could anyone test the new PR on macOS?

[bizz84]

@Megatron1000 @doffen @aporat Can you test if the required functionality works correctly on version 0.7.0? If this issue is not updated in the next few weeks it will be closed.

[doffen]

Sorry, I’m not able to test it. I forked my own version of the code, which I’m using only with XCode 7.3.1. Dave Offen From: Andrea Bizzotto [mailto:notifications@github.com] Sent: Saturday, February 04, 2017 2:20 PM To: bizz84/SwiftyStoreKit Cc: doffen; Mention Subject: Re: [bizz84/SwiftyStoreKit] Resolved repurchasing a non-consumable not calling completion, on macOS. (#105) @Megatron1000 <https://github.com/Megatron1000> @doffen <https://github.com/doffen> @aporat <https://github.com/aporat> Can you test if the required functionality works correctly on version 0.7.0? If this issue is not updated in the next few weeks it will be closed. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#105 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AIIXdlV0d8-0dVe05G7CBKhANjCIrW_dks5rZPmKgaJpZM4KviGL> . <https://github.com/notifications/beacon/AIIXdoh26-2VWD3O_CmNAnk7sH96AM6rks5rZPmKgaJpZM4KviGL.gif>

[bizz84]

I'm going to close this MR as the code has changed significantly since version 0.7.0.

If you still experience problems, please open a new issue.

[EzDream]

@bizz84 On OSX, I have updated to 0.10.2. unfortunely, The issue still exist.

[bizz84]

@EzDream Apologies for the late reply, it seems like there are a few open issues around purchases not working correctly. I have just found a bug in completeTransactions that may be relevant. See #322.