Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completeTransactions should not call completion block if there are no transactions to be processed #149

Closed
9 tasks done
bizz84 opened this issue Feb 25, 2017 · 2 comments
Closed
9 tasks done
Assignees

Comments

@bizz84
Copy link
Owner

bizz84 commented Feb 25, 2017

Platform

  • iOS
  • macOS
  • tvOS

In app purchase type

  • Consumable
  • Non-consumable
  • Auto-Renewable Subscription
  • Non-Renewing Subscription

Environment

  • Sandbox
  • Production

Version

0.8.1

Report

completeTransactions() completion block is called with zero products when making a purchase or restoring purchases.

Issue summary

  • Start SwiftyStoreKit demo app
  • Make a purchase or restore purchases
  • Wait for the payment queue to update with a transaction with state .purchased, .failed or .restored

What did you expect to happen

  • The callback of completeTransactions() should not be called.

What happened instead

  • The callback of completeTransactions() is called with zero products.
@bizz84 bizz84 self-assigned this Feb 25, 2017
bizz84 added a commit that referenced this issue Feb 25, 2017
@bizz84
Copy link
Owner Author

bizz84 commented Feb 25, 2017

Note: this bug doesn't have adverse effects in production as long as the array of products in the completion block is checked according to the README.

@bizz84
Copy link
Owner Author

bizz84 commented Feb 26, 2017

Fixed in pod version 0.8.2

@bizz84 bizz84 closed this as completed Feb 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant