Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include device application channel #4462

Closed
wants to merge 17 commits into from
Closed

Conversation

MGibson1
Copy link
Member

@MGibson1 MGibson1 commented Jul 4, 2024

Enables beta application push notifications

🎟️ Tracking

📔 Objective

Adds application channel to device registration, which enables beta publications with push notifications enabled.

WIP:
Depends on #4450
Still need to create EF migrations, but there were some additional migration changes that should be resolved by #4448

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Logo
Checkmarx One – Scan Summary & Details24395a3d-c450-4eff-8e17-02bdbeab858a

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 365 Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 222 Attack Vector
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 206 Attack Vector
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 215 Attack Vector
MEDIUM Privacy_Violation /src/Core/NotificationHub/NotificationHubPushNotificationService.cs: 191 Attack Vector
MEDIUM Privacy_Violation /src/Api/Vault/Models/Request/CipherRequestModel.cs: 198 Attack Vector
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 147 Attack Vector
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 628 Attack Vector
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 607 Attack Vector
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 657 Attack Vector
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 174 Attack Vector
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 159 Attack Vector
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 583 Attack Vector
LOW Log_Forging /src/Api/Controllers/PushController.cs: 71 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 147
MEDIUM Privacy_Violation /src/Core/NotificationHub/NotificationHubPushNotificationService.cs: 191
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 657
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 628
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 607
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 159
LOW Log_Forging /src/Api/Controllers/PushController.cs: 71

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 66.21622% with 75 lines in your changes missing coverage. Please review.

Project coverage is 41.13%. Comparing base (554a004) to head (bb5f2f4).
Report is 545 commits behind head on main.

Files with missing lines Patch % Lines
...ationHub/NotificationHubPushRegistrationService.cs 0.00% 19 Missing ⚠️
...SharedWeb/Utilities/ServiceCollectionExtensions.cs 10.52% 15 Missing and 2 partials ⚠️
src/Core/Models/Data/InstallationDeviceEntity.cs 0.00% 15 Missing ⚠️
...ationHub/NotificationHubPushNotificationService.cs 61.53% 5 Missing ⚠️
src/Api/Controllers/PushController.cs 0.00% 4 Missing ⚠️
.../Core/NotificationHub/NotificationHubConnection.cs 92.98% 2 Missing and 2 partials ⚠️
...es/Implementations/RelayPushRegistrationService.cs 0.00% 3 Missing ⚠️
.../Core/Models/Api/Request/PushUpdateRequestModel.cs 0.00% 2 Missing ⚠️
src/Core/Services/Implementations/DeviceService.cs 33.33% 2 Missing ⚠️
src/Api/Models/Request/DeviceRequestModels.cs 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4462      +/-   ##
==========================================
+ Coverage   40.90%   41.13%   +0.22%     
==========================================
  Files        1260     1263       +3     
  Lines       60106    60198      +92     
  Branches     5489     5496       +7     
==========================================
+ Hits        24589    24763     +174     
+ Misses      34382    34296      -86     
- Partials     1135     1139       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -9,7 +9,8 @@
@RevisionDate DATETIME2(7),
@EncryptedUserKey VARCHAR(MAX) = NULL,
@EncryptedPublicKey VARCHAR(MAX) = NULL,
@EncryptedPrivateKey VARCHAR(MAX) = NULL
@EncryptedPrivateKey VARCHAR(MAX) = NULL,
@ApplicationChannel TINYINT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ Defaults on procs are needed when parameters are added.

Base automatically changed from shard-notification-hub to main October 22, 2024 16:21
@MGibson1 MGibson1 closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants