Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-1288] Move AssociationWithPermissions public api model to AC Team #3584

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

eliykat
Copy link
Member

@eliykat eliykat commented Dec 15, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

The AssociationWithPermissions model is used to upsert CollectionUser or CollectionGroup associations via the Public API. It goes to OrganizationUser/Group permissions, so should be owned by AC Team. (Or arguably Vault, but I already discussed with @shane-melton and we agreed it could live with AC at least for now.)

I'm not sure why it's currently owned by Auth, maybe it was just scooped up with other file moves? Happy to discuss if there are any queries/issues here.

Code changes

  • file.ext: Description of what was changed and why

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@eliykat eliykat requested review from a team as code owners December 15, 2023 03:55
@ike-kottlowski ike-kottlowski removed their request for review December 20, 2023 17:07
@eliykat eliykat merged commit 73a793b into main Dec 21, 2023
41 checks passed
@eliykat eliykat deleted the ac/ac-1288/server-permissions branch December 21, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants