Remove the last references to Encryptable and Decryptable #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
==========================================
- Coverage 61.82% 61.80% -0.03%
==========================================
Files 173 172 -1
Lines 10947 10932 -15
==========================================
- Hits 6768 6756 -12
+ Misses 4179 4176 -3 ☔ View full report in Codecov by Sentry. |
dani-garcia
previously approved these changes
Apr 26, 2024
…table # Conflicts: # crates/bitwarden/src/tool/exporters/mod.rs
dani-garcia
approved these changes
Apr 26, 2024
Hinton
added a commit
that referenced
this pull request
May 31, 2024
In #738 we migrated away from `decrypt` and used `decrypt_with_key` instead. However ciphers can be encrypted using either organization keys or user key. The changes introduced meant we always used the users key instead of conditionally based on the value of `organization_jd` in `Cipher`. The fix was to call `locate_key` on `Cipher` and `Collection`. To properly write tests I needed to mock a user account and organization. I took this moment to refactor our tests account and we now have nice helpers for initializing the test@bitwarden.com account, which also includes an organization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Wrap up the migration to KeyEncryptable / KeyDecryptable.
Before you submit