Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-1973] Spellcheck #101

Closed
wants to merge 4 commits into from
Closed

Conversation

calvinballing
Copy link

@calvinballing calvinballing commented Apr 25, 2023

Objective

Fix various typos.

If the architecture decisions are meant as a historical record and shouldn't be touched, let me know and I'll drop that commit.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-1973

@bitwarden-bot bitwarden-bot changed the title Spellcheck [PM-1973] Spellcheck Apr 25, 2023
@djsmith85
Copy link
Contributor

@calvinballing Thank you for your contribution. Just an FYI, there's another PR #92 which has a similar goal.

@calvinballing
Copy link
Author

Thanks, I’ll take a look and see where the overlap is.

@calvinballing
Copy link
Author

@calvinballing Thank you for your contribution. Just an FYI, there's another PR #92 which has a similar goal.

Given that introducing cspell seems to be contentious, I think having this as a standalone PR to just fix the typos without making workflow changes might be beneficial, as that one may not get merged.

@Hinton
Copy link
Member

Hinton commented Jun 5, 2023

Hi @calvinballing,

Thanks for the contribution.

We decided to go ahead and extract the spelling fixes from #92 into a separate PR, #129 which is now merged. I believe #129 contains all spelling fixes covered by this PR.

I'm going to close this, and while we didn't get a chance to merge this PR we appreciate the effort gone into the PR.

@Hinton Hinton closed this Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants