-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-3797 Part 2] Create Account Recovery Service #6667
Conversation
7bab555
to
cde3ce3
Compare
e42a67e
to
b5d6e61
Compare
cde3ce3
to
48ab69b
Compare
b5d6e61
to
45345cb
Compare
7f77d3b
to
bd3d171
Compare
7a25bfe
to
c179925
Compare
The base branch was changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need a module? Can't we directly provide AccountRecoveryService
in a consuming component's providers
? Even better, can AccountRecoveryService
just be providedIn: "root"
?
apps/web/src/app/auth/emergency-access/emergency-access.module.ts
Outdated
Show resolved
Hide resolved
96c44a0
to
82a5755
Compare
New Issues
|
My previous review was on code that was removed by the force push
82a5755
to
4417214
Compare
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
4417214
to
953e7d4
Compare
953e7d4
to
9620161
Compare
9620161
to
2c4a5d6
Compare
Type of change
Objective
Consolidates account recovery logic into a service shared between components.
Part 2 of a PR stack intended in refactoring the key rotation logic.
Part 1 (Emergency Access): #6612
Note: After some feedback from AC, I've renamed
AccountRecoveryService
toOrganizationUserResetPasswordService
in the next PR. Although we will eventually migrate the name to account recovery, doing it in these changes would leave it overall in a half migrated and confusing state.Code changes
ViewContainerRef
to theResetPasswordComponent
so it can resolve theAccountRecoveryService
as a dependency.Screenshots
Before you submit