Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17088] Prevent lock component init when switching to unlocked account #12875

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jlf0dev
Copy link
Member

@jlf0dev jlf0dev commented Jan 14, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17088

📔 Objective

When a new user is selected through account switching, the new lock component will reinitialize with that user. If that user is unlocked, the app will quickly redirect to vault, but that reinitialization was still running. This meant that things like bio prompts would show before switching to vault.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jlf0dev jlf0dev requested a review from a team as a code owner January 14, 2025 22:30
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details8af50691-4e9c-461b-bbf2-f787ae7b01e0

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 34.27%. Comparing base (6f018e1) to head (44fa477).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ment/src/angular/lock/components/lock.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12875      +/-   ##
==========================================
- Coverage   34.27%   34.27%   -0.01%     
==========================================
  Files        2935     2935              
  Lines       90232    90234       +2     
  Branches    16943    16944       +1     
==========================================
  Hits        30931    30931              
- Misses      56837    56839       +2     
  Partials     2464     2464              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants