Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17042] Biometrics auto prompt popup does not show up on safari #12868

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

mzieniukbw
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17042

📔 Objective

This is due to missing await before process reload, triggered by lock, effectively disabling the biometrics auto prompt on safari.
This should be detected by eslint, but due to misconfiguration, nothing was reported. Also fixed two other missing awaits on biometrics unlock.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

This is due to missing await before process reload, triggered by lock, effectively disabling the biometrics auto prompt on safari.
This should be detected by eslint, but due to misconfiguration, nothing was reported. Also fixed two other missing awaits on biometrics unlock.
@mzieniukbw mzieniukbw requested a review from a team as a code owner January 14, 2025 19:19
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details35043b8c-ce73-41b0-93ca-bcfbb0bf6433

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 34.28%. Comparing base (f44b36b) to head (e535491).
Report is 11 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...iometrics/background-browser-biometrics.service.ts 0.00% 2 Missing ⚠️
apps/browser/src/popup/app.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12868      +/-   ##
==========================================
- Coverage   34.28%   34.28%   -0.01%     
==========================================
  Files        2934     2934              
  Lines       90225    90210      -15     
  Branches    16944    16942       -2     
==========================================
- Hits        30937    30930       -7     
+ Misses      56824    56816       -8     
  Partials     2464     2464              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mzieniukbw mzieniukbw merged commit bdab4aa into main Jan 15, 2025
84 checks passed
@mzieniukbw mzieniukbw deleted the km/pm-17042 branch January 15, 2025 15:29
mzieniukbw added a commit that referenced this pull request Jan 15, 2025
…2868)

This is due to missing await before process reload, triggered by lock, effectively disabling the biometrics auto prompt on safari.
This should be detected by eslint, but due to misconfiguration, nothing was reported. Also fixed two other missing awaits on biometrics unlock.

(cherry picked from commit bdab4aa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants