Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7317][Web] Clean up old components #12862

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cyprain-okeke
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-7317

📔 Objective

When all marketing content has been changed to use the new Trial Initiation flow, we can remove the obsolete components:

TrialInitiationComponent

app-registration-form

Guard implemented in https://bitwarden.atlassian.net/browse/PM-7373

In addition, we should redirect /register to /signup.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cyprain-okeke cyprain-okeke requested a review from a team as a code owner January 14, 2025 16:12
@cyprain-okeke cyprain-okeke requested a review from rr-bw January 14, 2025 16:12
Copy link
Contributor

github-actions bot commented Jan 14, 2025

Logo
Checkmarx One – Scan Summary & Details60e521a1-865d-4176-ab0c-c32569275b78

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 34.19%. Comparing base (f44b36b) to head (5249502).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...er/secrets-manager-trial-paid-stepper.component.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12862      +/-   ##
==========================================
- Coverage   34.28%   34.19%   -0.10%     
==========================================
  Files        2934     2931       -3     
  Lines       90225    90002     -223     
  Branches    16944    16885      -59     
==========================================
- Hits        30937    30779     -158     
+ Misses      56824    56801      -23     
+ Partials     2464     2422      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cyprain-okeke cyprain-okeke requested a review from a team as a code owner January 14, 2025 19:10
@cyprain-okeke cyprain-okeke requested a review from coroiu January 14, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants