Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL-524] Ignore kitchen sink virtual scroll story #12858

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

vleague2
Copy link
Contributor

@vleague2 vleague2 commented Jan 14, 2025

🎟️ Tracking

CL-524

📔 Objective

The kitchen sink virtual scroll story is still causing unwanted diffs because the previous method used to ignore changes (data-chromatic=ignore) does not ignore height changes, which is exactly what's causing the diffs. Skipping the whole test for now until we can figure out why the row count is inconsistent.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vleague2 vleague2 marked this pull request as ready for review January 14, 2025 14:56
@vleague2 vleague2 requested a review from a team as a code owner January 14, 2025 14:56
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsd6753a4c-455c-4dc4-a2cc-8e01075eff77

Great job, no security vulnerabilities found in this Pull Request

Copy link
Contributor

@willmartian willmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get out of here!

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.29%. Comparing base (6d07a49) to head (e1d9c13).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12858      +/-   ##
==========================================
- Coverage   34.30%   34.29%   -0.01%     
==========================================
  Files        2934     2934              
  Lines       90188    90188              
  Branches    16939    16939              
==========================================
- Hits        30937    30930       -7     
- Misses      56787    56794       +7     
  Partials     2464     2464              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vleague2 vleague2 merged commit e568a7a into main Jan 14, 2025
86 checks passed
@vleague2 vleague2 deleted the uif/cl-524/kitchen-sink-story branch January 14, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants