Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16924] Fix bad imports #12803

Merged
merged 1 commit into from
Jan 10, 2025
Merged

[PM-16924] Fix bad imports #12803

merged 1 commit into from
Jan 10, 2025

Conversation

jprusik
Copy link
Contributor

@jprusik jprusik commented Jan 10, 2025

🎟️ Tracking

PM-16924

📔 Objective

Fix bad/restricted import paths

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jprusik jprusik self-assigned this Jan 10, 2025
@jprusik jprusik requested a review from a team as a code owner January 10, 2025 14:19
@jprusik jprusik requested a review from Hinton January 10, 2025 14:25
Copy link
Member

@Hinton Hinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a hold off until #12744 is merged since we have 3 of 6 reviews and since it's getting close to end of workweek in EU.

Looks good otherwise.

@Hinton Hinton added the hold do not merge, do not approve yet label Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.14%. Comparing base (c0dfac4) to head (09a2517).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12803   +/-   ##
=======================================
  Coverage   34.13%   34.14%           
=======================================
  Files        2936     2936           
  Lines       90428    90428           
  Branches    16988    16988           
=======================================
+ Hits        30869    30876    +7     
+ Misses      57102    57095    -7     
  Partials     2457     2457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 10, 2025

Logo
Checkmarx One – Scan Summary & Details61eae585-7ef0-4dbb-bb8a-0b086364c48e

No New Or Fixed Issues Found

@Hinton Hinton removed the hold do not merge, do not approve yet label Jan 10, 2025
@jprusik jprusik force-pushed the pm-16924 branch 2 times, most recently from 73d61c0 to 602ff90 Compare January 10, 2025 16:42
@jprusik jprusik requested a review from Hinton January 10, 2025 16:42
@jprusik jprusik merged commit 9e33e69 into main Jan 10, 2025
37 checks passed
@jprusik jprusik deleted the pm-16924 branch January 10, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants