Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-16170 remove methods using deprecated send endpoints #12751

Merged

Conversation

prograhamming
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/jira/software/c/projects/BW/boards/92?selectedIssue=PM-16170

📔 Objective

Within server there’s a deprecated endpoint for uploading files to a Bitwarden Send (SendsController). This endpoint can be removed. In addition any backwards compatible logic on the client-side (send-api.service) can also be removed.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@prograhamming prograhamming requested a review from a team as a code owner January 8, 2025 15:14
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Logo
Checkmarx One – Scan Summary & Detailsc05e5053-1e9b-4632-9e2c-0394e83f86fb

Great job, no security vulnerabilities found in this Pull Request

Copy link
Contributor

@djsmith85 djsmith85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Changes are looking good!

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 34.28%. Comparing base (a54508a) to head (77be85b).
Report is 21 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...common/src/tools/send/services/send-api.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12751      +/-   ##
==========================================
- Coverage   34.28%   34.28%   -0.01%     
==========================================
  Files        2933     2933              
  Lines       90081    90066      -15     
  Branches    16916    16914       -2     
==========================================
- Hits        30886    30879       -7     
+ Misses      56737    56729       -8     
  Partials     2458     2458              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prograhamming prograhamming merged commit 8621e8a into main Jan 14, 2025
83 of 84 checks passed
@prograhamming prograhamming deleted the tools/pm-16170/remove-deprecated-sends-endpoint-from-client branch January 14, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants