[PM-12759] - Admin Console - Link to vault cipher is not opening cipher modal

[jaasen-livefront]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12759

📔 Objective

This PR fixes an issue where on initial load the org vault cipher dialog was not opening even when itemId and action=view params were present. This was due to the use of withLatestFrom which was firing on first emission of the query param observable but the array of observables passed in (allCipherMap$, allCollections$, organization$) had not yet emitted and thus the stream was halted. Using switchMap ensures all observables have emitted before running.

Steps to test for success:

• navigate to an org and click on a vault item
• reload page
• item modal should appear

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 34.15%. Comparing base (bb61b3d) to head (13d7b73).

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...pps/web/src/app/vault/org-vault/vault.component.ts	0.00%	9 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #12738   +/-   ##
=======================================
  Coverage   34.14%   34.15%           
=======================================
  Files        2937     2937           
  Lines       90340    90345    +5     
  Branches    16963    16964    +1     
=======================================
+ Hits        30846    30853    +7     
+ Misses      57039    57037    -2     
  Partials     2455     2455           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Jingo88]

I believe switching this to combineLatest is going to have multiple emissions from the observable. The withLatestFrom was to address this bug previously PM-12678

this change also seems to result in the edit modal being called multiple times. Screen recording below:

PM-12759.mov

[jaasen-livefront]

@Jingo88 Ok I've added some logic to prevent double rendering. Let me know what you think!