[PM-16227] Move import to sdk and enable it in browser/web #12479
+403
−630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed Issues (78)Great job! The following issues were fixed in this Pull Request
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…rden/clients into km/pm-16227/ssh-import-web-browser
audreyality
reviewed
Jan 6, 2025
Comment on lines
846
to
849
| } else { | ||
| password = await this.getSshKeyPassword(); | ||
| await this.importSshKeyFromClipboard(password); | ||
| } |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
libs/vault/src/cipher-form/components/sshkey-section/sshkey-section.component.ts
Outdated
Show resolved
Hide resolved
libs/vault/src/cipher-form/components/sshkey-section/sshkey-section.component.ts
Outdated
Show resolved
Hide resolved
…ction.component.ts Co-authored-by: SmithThe4th <gsmith@bitwarden.com>
…rden/clients into km/pm-16227/ssh-import-web-browser
gbubemismith
previously approved these changes
Jan 23, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com>
…rden/clients into km/pm-16227/ssh-import-web-browser
audreyality
approved these changes
Jan 24, 2025
gbubemismith
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16227
📔 Objective
Makes use of the sdk in order to handle import on desktop web and browser. Drops importer code from
desktop_nativesince it's not needed there anymore.📸 Screenshots
Screen.Recording.2025-01-15.at.12.59.04.mov
Screen.Recording.2025-01-15.at.12.52.06.mov
Failed import:
Screen.Recording.2025-01-15.at.13.10.25.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes