New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use std::min(), std::max() #138

Closed

ckerr wants to merge 1 commit into bittorrent:master from transmission:refactor/replace-bespoke-to-std-pt-2

ckerr commented Oct 19, 2023

Dusting off an older PR. This is a followup to transmission#7 and is described in that PR description.

Part two of a three-part series to use std:: tools instead of bespoke ones. Part three will fix #6.

Part 1: remove Array; use std::vector instead (x86_64 support requires -fPIC #7)
Part 2: remove min, max; use std::min, std::max instead (this PR)
Part 3: remove utpHashTable; use std::unordered_map instead

Unfortunately there don't seem to be any real tests for libutp, so the need to manually test is even greater than usual.


          refactor: use std::min(), std::max()

735bb59

mikedld approved these changes

View reviewed changes

Author

ckerr commented Oct 19, 2023

whoops, targeted to the wrong branch. Sorry for the noise; will resubmit

ckerr closed this

ckerr deleted the refactor/replace-bespoke-to-std-pt-2 branch

October 20, 2023 00:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet