Fix DHT typo #119
Open
Fix DHT typo #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this change makes sense. It's quite confusing to have so many mentions of "find_nodes". What makes it worse is that the plural version would really make more sense, since the response most likely will have more than one node. |
Nominally it is to find a node with a specific ID, e.g. when searching for yourself during bootstrap. You just "happen" to find neighbors along the way. Of course the latter is the real use. |
arvidn
approved these changes
Mar 9, 2021
|
I am cleaning up my open PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no such thing as
find_nodesin the DHT protocol, I think it should befind_node(without the s).I know it's a nitpick. Feel free to close if you feel like it is bikeshedding.