Skip to content
This repository has been archived by the owner on Feb 19, 2020. It is now read-only.

Bump to iOS 9 and fix feedback layout #508

Merged
merged 8 commits into from
Jan 25, 2018
+193 −419
Merged

Bump to iOS 9 and fix feedback layout #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d48961d
Bump deployment target to iOS 9
MatkovIvan Jan 24, 2018
84e99c5
Cleanup deprecations
MatkovIvan Jan 24, 2018
81ff8ed
Remove reduntant version checks
MatkovIvan Jan 24, 2018
4324a26
Fix images ratio in feedback's scrollview, remove action sheet delega…
MatkovIvan Jan 25, 2018
ea6b16c
Fix feedback's scrollview position on orientation change and on iPhone X
MatkovIvan Jan 25, 2018
2230076
Fix feedback layout on previous iOS versions
MatkovIvan Jan 25, 2018
95a6eb1
Cleanup deprecations
MatkovIvan Jan 25, 2018
5300f8a
Remove deprecated orientation callbacks
MatkovIvan Jan 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Classes/BITAttributedLabel.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
#define kBITLineBreakWordWrapTextWidthScalingFactor (M_PI / M_E)

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
#pragma clang diagnostic ignored "-Wunused-variable"
#pragma clang diagnostic ignored "-Wunused-parameter"
#pragma clang diagnostic ignored "-Wcast-qual"
Expand Down
3 changes: 0 additions & 3 deletions Classes/BITCrashCXXExceptionHandler.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,6 @@ static inline void BITCrashIterateExceptionHandlers_unlocked(const BITCrashUncau
}
}

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
static void BITCrashUncaughtCXXTerminateHandler(void)
{
BITCrashUncaughtCXXExceptionInfo info = {
Expand Down Expand Up @@ -240,7 +238,6 @@ + (void)removeCXXExceptionHandler:(BITCrashUncaughtCXXExceptionHandler)handler
}
} OSSpinLockUnlock(&_BITCrashCXXExceptionHandlingLock);
}
#pragma clang diagnostic pop

@end

Expand Down
9 changes: 6 additions & 3 deletions Classes/BITCrashManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,8 @@ - (void) registerObservers {
NSNotificationName name = UIApplicationDidBecomeActiveNotification;
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wpartial-availability"
if (bit_isRunningInAppExtension() && &NSExtensionHostDidBecomeActiveNotification != NULL) {
#pragma clang diagnostic ignored "-Wtautological-pointer-compare"
if (bit_isRunningInAppExtension() && &NSExtensionHostDidBecomeActiveNotification != nil) {
name = NSExtensionHostDidBecomeActiveNotification;
}
#pragma clang diagnostic pop
Expand Down Expand Up @@ -515,7 +516,8 @@ - (void) registerObservers {
NSNotificationName name = UIApplicationDidEnterBackgroundNotification;
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wpartial-availability"
if (bit_isRunningInAppExtension() && &NSExtensionHostDidEnterBackgroundNotification != NULL) {
#pragma clang diagnostic ignored "-Wtautological-pointer-compare"
if (bit_isRunningInAppExtension() && &NSExtensionHostDidEnterBackgroundNotification != nil) {
name = NSExtensionHostDidEnterBackgroundNotification;
}
#pragma clang diagnostic pop
Expand All @@ -532,7 +534,8 @@ - (void) registerObservers {
NSNotificationName name = UIApplicationWillEnterForegroundNotification;
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wpartial-availability"
if (bit_isRunningInAppExtension() && &NSExtensionHostWillEnterForegroundNotification != NULL) {
#pragma clang diagnostic ignored "-Wtautological-pointer-compare"
if (bit_isRunningInAppExtension() && &NSExtensionHostWillEnterForegroundNotification != nil) {
name = NSExtensionHostWillEnterForegroundNotification;
}
#pragma clang diagnostic pop
Expand Down
4 changes: 1 addition & 3 deletions Classes/BITCrashReportTextFormatter.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,8 +277,7 @@ + (NSString *)stringValueForCrashReport:(BITPLCrashReport *)report crashReporter
if (codeType != nil)
break;
}
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"

/* If we were unable to determine the code type, fall back on the legacy architecture value. */
if (codeType == nil) {
switch (report.systemInfo.architecture) {
Expand All @@ -305,7 +304,6 @@ + (NSString *)stringValueForCrashReport:(BITPLCrashReport *)report crashReporter
break;
}
}
#pragma GCC diagnostic pop
}

{
Expand Down
Loading