Merge pull request #508 from MatkovIvan/feature/bump-minsdk-to-ios-9

Bump to iOS 9 and fix feedback layout
bitstadium · Jan 25, 2018 · 797fd06 · 797fd06
2 parents 3ce7e4d + 5300f8a
commit 797fd06
Show file tree

Hide file tree

Showing 19 changed files with 193 additions and 419 deletions.
diff --git a/Classes/BITAttributedLabel.m b/Classes/BITAttributedLabel.m
@@ -33,7 +33,6 @@
 #define kBITLineBreakWordWrapTextWidthScalingFactor (M_PI / M_E)
 
 #pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 #pragma clang diagnostic ignored "-Wunused-variable"
 #pragma clang diagnostic ignored "-Wunused-parameter"
 #pragma clang diagnostic ignored "-Wcast-qual"

diff --git a/Classes/BITCrashCXXExceptionHandler.mm b/Classes/BITCrashCXXExceptionHandler.mm
@@ -130,8 +130,6 @@ static inline void BITCrashIterateExceptionHandlers_unlocked(const BITCrashUncau
   }
 }
 
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 static void BITCrashUncaughtCXXTerminateHandler(void)
 {
   BITCrashUncaughtCXXExceptionInfo info = {
@@ -240,7 +238,6 @@ + (void)removeCXXExceptionHandler:(BITCrashUncaughtCXXExceptionHandler)handler
     }
   } OSSpinLockUnlock(&_BITCrashCXXExceptionHandlingLock);
 }
-#pragma clang diagnostic pop
 
 @end
 

diff --git a/Classes/BITCrashManager.m b/Classes/BITCrashManager.m
@@ -478,7 +478,8 @@ - (void) registerObservers {
     NSNotificationName name = UIApplicationDidBecomeActiveNotification;
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wpartial-availability"
-    if (bit_isRunningInAppExtension() && &NSExtensionHostDidBecomeActiveNotification != NULL) {
+#pragma clang diagnostic ignored "-Wtautological-pointer-compare"
+    if (bit_isRunningInAppExtension() && &NSExtensionHostDidBecomeActiveNotification != nil) {
       name = NSExtensionHostDidBecomeActiveNotification;
     }
 #pragma clang diagnostic pop
@@ -515,7 +516,8 @@ - (void) registerObservers {
     NSNotificationName name = UIApplicationDidEnterBackgroundNotification;
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wpartial-availability"
-    if (bit_isRunningInAppExtension() && &NSExtensionHostDidEnterBackgroundNotification != NULL) {
+#pragma clang diagnostic ignored "-Wtautological-pointer-compare"
+    if (bit_isRunningInAppExtension() && &NSExtensionHostDidEnterBackgroundNotification != nil) {
       name = NSExtensionHostDidEnterBackgroundNotification;
     }
 #pragma clang diagnostic pop
@@ -532,7 +534,8 @@ - (void) registerObservers {
     NSNotificationName name = UIApplicationWillEnterForegroundNotification;
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wpartial-availability"
-    if (bit_isRunningInAppExtension() && &NSExtensionHostWillEnterForegroundNotification != NULL) {
+#pragma clang diagnostic ignored "-Wtautological-pointer-compare"
+    if (bit_isRunningInAppExtension() && &NSExtensionHostWillEnterForegroundNotification != nil) {
       name = NSExtensionHostWillEnterForegroundNotification;
     }
 #pragma clang diagnostic pop

diff --git a/Classes/BITCrashReportTextFormatter.m b/Classes/BITCrashReportTextFormatter.m
@@ -277,8 +277,7 @@ + (NSString *)stringValueForCrashReport:(BITPLCrashReport *)report crashReporter
       if (codeType != nil)
         break;
     }
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+
     /* If we were unable to determine the code type, fall back on the legacy architecture value. */
     if (codeType == nil) {
       switch (report.systemInfo.architecture) {
@@ -305,7 +304,6 @@ + (NSString *)stringValueForCrashReport:(BITPLCrashReport *)report crashReporter
           break;
       }
     }
-#pragma GCC diagnostic pop
   }
 
   {