Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more i16/u16 tests; fix cuda align for i16/u16 #440

Merged
merged 2 commits into from
Nov 26, 2023

Conversation

kawogi
Copy link
Contributor

@kawogi kawogi commented Nov 26, 2023

This is a follow-up for #439, adding the missing test cases (and some more).

Also the CUDA-alignment has been fixed (to my knowledge).

Test-coverage should at least be back to normal. API is backwards-compatible (no version-bump required IMO).

@kawogi kawogi mentioned this pull request Nov 26, 2023
@bitshifter
Copy link
Owner

This is the alignment table I've been using, https://docs.nvidia.com/cuda/archive/11.7.0/cuda-c-programming-guide/index.html#vector-types__alignment-requirements-in-device-code. I think what you have looks about right.

Thanks for all your work here!

@bitshifter bitshifter merged commit 9be932e into bitshifter:main Nov 26, 2023
15 checks passed
@kawogi
Copy link
Contributor Author

kawogi commented Nov 27, 2023

Thanks for checking. I'm happy to give something back and your crate was super easy to work with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants